Re: vectorized CRC on ARM64

On Sun, Apr 5, 2026 at 1:36 AM Tomas Vondra <tomas(at)vondra(dot)me> wrote:
> I happened to do some testing on rpi5 with a 32-bit user space, and when
> building with this commit I get these warnings from clang:

> pg_crc32c_armv8_choose.c:112:1: warning: unused function
> 'pg_pmull_available' [-Wunused-function]
> 112 | pg_pmull_available(void)
> | ^~~~~~~~~~~~~~~~~~
> 1 warning generated.
>
> I suppose the pg_pmull_available() needs to be if-defed with
> USE_PMULL_CRC32C_WITH_RUNTIME_CHECK. That removes the warning for me, at
> least.

Hmm, it looks like gcc is different in that it won't warn on unused
static inlines, only unused statics. The fix is right, so done that
way, thanks for the report!

--
John Naylor
Amazon Web Services