Re: On login trigger: take three

From: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: On login trigger: take three
Date: 2020-12-17 13:05:18
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 17.12.2020 3:31, Zhihong Yu wrote:
> Hi,
> For EventTriggerOnConnect():
> +           PG_CATCH();
> +           {
> ...
> +               AbortCurrentTransaction();
> +               return;
> Should runlist be freed in the catch block ?

No need: it is allocated in transaction memory context and removed on
transaction abort.

> +           gettext_noop("In case of errors in the ON
> client_connection EVENT TRIGGER procedure, this parameter can be used
> to disable trigger activation and provide access to the database."),
> I think the text should be on two lines (current line too long).

Thank you, fixed.

Konstantin Knizhnik
Postgres Professional:
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Denis Smirnov 2020-12-17 13:39:50 Re: libpq compression
Previous Message Konstantin Knizhnik 2020-12-17 13:03:56 Re: On login trigger: take three