Re: On login trigger: take three

From: Zhihong Yu <zyu(at)yugabyte(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: On login trigger: take three
Date: 2020-12-17 00:31:08
Message-ID: CALNJ-vQK2V1op-kEYmwo=3wW4sx7G7ngY58x0OOQELn=Y5KG3w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
For EventTriggerOnConnect():

+ PG_CATCH();
+ {
...
+ AbortCurrentTransaction();
+ return;

Should runlist be freed in the catch block ?

+ gettext_noop("In case of errors in the ON client_connection
EVENT TRIGGER procedure, this parameter can be used to disable trigger
activation and provide access to the database."),

I think the text should be on two lines (current line too long).

Cheers

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-12-17 01:24:56 Re: Proposed patch for key managment
Previous Message Daniel Gustafsson 2020-12-17 00:15:37 Re: Proposed patch for key managment