Re[2]: Adding a note to protocol.sgml regarding CopyData

From: "Bradley DeJong" <bpd0018(at)gmail(dot)com>
To: "Fabien COELHO" <coelho(at)cri(dot)ensmp(dot)fr>, "Tatsuo Ishii" <ishii(at)sraoss(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re[2]: Adding a note to protocol.sgml regarding CopyData
Date: 2018-08-26 21:19:18
Message-ID: em6fdb9379-85da-4e57-96c1-02f507b1b3ae@dolphin
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2018-08-25, Tatsuo Ishii wrote to the pgsql-docs mailing list ...
> Hi Bradley,
> Thank you for your follow up. Your patch looks good to me.
> Can you please re-send your message in pgsql-hackers attaching to this
thread ...
> CommitFest app does not allow ... emails other than posted to
pgsql-hackers. So I
> decided to post to pgsql-hackers after posting to pgsql-docs. ...

OK, I think this is what you wanted.

Fabian's suggestion on making the removal more assertive is included in
the v2 patch.

On 2018-08- Bradley DeJong wrote ...
>On 2018-07-27, Tatsuo Ishii wrote ...
>>... I think this should be mentioned in protocol.sgml as well. ...
> I agree. It is already mentioned as one of the differences between v2
> and v3 but an implementer should not need to read that section if they
> are only implementing v3. (I know I've never looked at it before.)
> Using protocol.diff as a base, I changed the phrasing to be more
> prescriptive for v3 protocol implementers (don't send a final line, be
> prepared to receive a final line), changed passive voice to active
> voice and fixed one COPYData -> CopyData capitalization.
> I also called this out in the description of the CopyData message
> format because that is where the termination line would be
> transmitted.

Attachment Content-Type Size
protocol.v2.patch application/octet-stream 2.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-08-26 21:38:53 Re: Small patch to remove some duplicate words in comments
Previous Message Tom Lane 2018-08-26 20:09:37 Re: Something's busted in plpgsql composite-variable handling