From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Default setting for enable_hashagg_disk |
Date: | 2020-06-22 17:30:43 |
Message-ID: | ee1a7be071349b93c01ffb9ef4cf3a6830d9e780.camel@j-davis.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs pgsql-hackers |
On Mon, 2020-06-22 at 10:52 -0400, Robert Haas wrote:
> So I feel like the really important thing here is to fix the cases
> that don't come out well with default settings.
...with the caveat that perfection is not something to expect from our
planner.
> If we can't do that,
> then the feature is half-baked and maybe should not have been
> committed in the first place.
HashAgg started out half-baked at the dawn of time, and stayed that way
through version 12. Disk-based HashAgg was designed to fix it.
Other major planner features generally offer a way to turn them off
(e.g. parallelism, JIT), and we don't call those half-baked.
I agree that the single GUC added in v13 (hashagg_avoid_disk_plan) is
weird because it's half of a disable switch. But it's not weird because
of my changes in v13; it's weird because the planner behavior in v12
was weird. I hope not many people need to set it, and I hope we can
remove it soon.
If you think we will never be able to remove the GUC, then we should
think a little harder about whether we really need it. I am open to
that discussion, but I don't think the presence of this GUC implies
that disk-based hashagg is half-baked.
Regards,
Jeff Davis
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2020-06-22 17:43:48 | Re: Summary of DDL/DML statement return/output values? |
Previous Message | Steve Estes | 2020-06-22 16:48:55 | Summary of DDL/DML statement return/output values? |
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2020-06-22 17:44:47 | Re: Default setting for enable_hashagg_disk |
Previous Message | Alexey Kondratov | 2020-06-22 17:18:58 | Re: [PATCH] Allow to specify restart_lsn in pg_create_physical_replication_slot() |