| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: automating perl compile time checking |
| Date: | 2018-06-11 19:38:57 |
| Message-ID: | ed75685f-a4cf-45d1-6554-e5a441b596f7@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06/11/2018 02:33 PM, Alvaro Herrera wrote:
> On 2018-Jun-05, Daniel Gustafsson wrote:
>
>>> On 5 Jun 2018, at 16:31, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
>>> The patch contains a simple script to run the checks. The code that finds perl files is put in a function in a single file that is sourced by the three locations that need it.
>> +1 on centralizing the find-files function.
> +1 on that. Why do we need to make the new find_perl_files file
> executable, given it's always sourced? (I would have given a .sh
> extension because it's a lib not an executable, but I suppose that's
> just matter of taste; we certainly don't have a policy about it).
>
> Looks fine to me either way.
>
I've committed this, but I'm fine if people want to tweak the names. It
probably doesn't need to be executable.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-06-11 20:01:27 | Re: automating perl compile time checking |
| Previous Message | Tom Lane | 2018-06-11 19:03:39 | Re: PostgreSQL vs SQL Standard |