Re: pgsql: Support SCRAM-SHA-256 authentication (RFC 5802 and 7677).

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Support SCRAM-SHA-256 authentication (RFC 5802 and 7677).
Date: 2017-03-07 16:00:52
Message-ID: ec8d7581-c403-11c1-b708-dce08be79197@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 03/07/2017 04:07 PM, Peter Eisentraut wrote:
> On 3/7/17 07:26, Heikki Linnakangas wrote:
>> Support SCRAM-SHA-256 authentication (RFC 5802 and 7677).
>
> This is probably a mistake:
>
> fe-auth.c: In function 'pg_SASL_init':
> fe-auth.c:453:24: error: logical 'or' of equal expressions [-Werror=logical-op]
> if (password == NULL || password == '\0')
> ^~
>
> Did you mean password[0] == '\0'?

Thanks, will fix!

I also noticed that the HPUX buildfarm members pademelon and gaur
failed, with this:

/usr/ccs/bin/ld: Unsatisfied symbols:
htonl (code)

I will look into that too.

- Heikki

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-03-07 16:06:30 Re: pgsql: Support SCRAM-SHA-256 authentication (RFC 5802 and 7677).
Previous Message Robert Haas 2017-03-07 15:59:04 pgsql: Document what values postgres_fdw sets for each parameter it set