Re: pgsql: Fix parsing of integer values for connection parameters in libpq

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix parsing of integer values for connection parameters in libpq
Date: 2019-10-22 08:05:45
Message-ID: ec64956b-4597-56b6-c3db-457d15250fe4@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2019-10-21 04:18, Michael Paquier wrote:
> Fix parsing of integer values for connection parameters in libpq

Something in this code doesn't make sense:

+ /*
+ * Skip any trailing whitespace; if anything but whitespace remains
before
+ * the terminating character, fail
+ */
+ while (*end && *end != '\0' && isspace((unsigned char) *end))
+ end++;
+
+ if (*end && *end != '\0')
+ goto error;

You probably want something like

if (end && *end != ...)

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2019-10-22 08:07:31 pgsql: Fix comment
Previous Message Alexander Korotkov 2019-10-21 20:11:38 pgsql: Refactor timestamp2timestamptz_opt_error()