Re: pgsql: Fix parsing of integer values for connection parameters in libpq

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix parsing of integer values for connection parameters in libpq
Date: 2019-10-22 10:05:53
Message-ID: 20191022100553.GA3908@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Oct 22, 2019 at 10:05:45AM +0200, Peter Eisentraut wrote:
> You probably want something like
>
> if (end && *end != ...)

Yes, it looks like a brain fade here. Conversion failures are tracked
before that, so strtol() would not return NULL for endptr. The first
part could just be removed as per the attached.
--
Michael

Attachment Content-Type Size
libpq-parse-fix.patch text/x-diff 622 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-10-23 01:27:42 pgsql: Clean up properly error_context_stack in autovacuum worker on ex
Previous Message Peter Eisentraut 2019-10-22 08:37:02 pgsql: Make command order in test more sensible