| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Georgios Kokolatos <gkokolatos(at)protonmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_upgrade analyze script |
| Date: | 2020-11-09 14:47:22 |
| Message-ID: | ea403f46-2b33-a7de-618e-9cab35a698c8@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-11-09 11:22, Magnus Hagander wrote:
>> I have spotted one small-ish thing. This patch is missing to update
>> the following code in vcregress.pl:
>> print "\nSetting up stats on new cluster\n\n";
>> system(".\\analyze_new_cluster.bat") == 0 or exit 1;
> Ah, nice catch -- thanks! I guess this is unfortunately not a test
> that's part of what cfbot tests.
>
> Untested on Windows, but following the patterns of the rows before it.
> I will go ahead and push this version in a bit.
You should just remove those calls. There is no need to replace them
with vacuumdb calls. The reason those calls were there is that they
were testing the generated script itself. If the script is gone, there
is no more need. There are already separate tests for testing vacuumdb.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jehan-Guillaume de Rorthais | 2020-11-09 14:50:49 | Re: vacuum -vs reltuples on insert only index |
| Previous Message | Alvaro Herrera | 2020-11-09 14:42:33 | Re: Rethinking LOCK TABLE's behavior on views |