From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Georgios Kokolatos <gkokolatos(at)protonmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pg_upgrade analyze script |
Date: | 2020-11-11 15:50:24 |
Message-ID: | CABUevExM1yBp=C1LT2Qiv=u1UXGg_-O=K7FYZ95SFzGCTV5+Mg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Nov 9, 2020 at 3:47 PM Peter Eisentraut
<peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> On 2020-11-09 11:22, Magnus Hagander wrote:
> >> I have spotted one small-ish thing. This patch is missing to update
> >> the following code in vcregress.pl:
> >> print "\nSetting up stats on new cluster\n\n";
> >> system(".\\analyze_new_cluster.bat") == 0 or exit 1;
> > Ah, nice catch -- thanks! I guess this is unfortunately not a test
> > that's part of what cfbot tests.
> >
> > Untested on Windows, but following the patterns of the rows before it.
> > I will go ahead and push this version in a bit.
>
> You should just remove those calls. There is no need to replace them
> with vacuumdb calls. The reason those calls were there is that they
> were testing the generated script itself. If the script is gone, there
> is no more need. There are already separate tests for testing vacuumdb.
>
Good point. Done.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2020-11-11 15:51:27 | Re: pg_upgrade analyze script |
Previous Message | Alvaro Herrera | 2020-11-11 15:17:36 | Re: proposal: possibility to read dumped table's name from file |