Re: pg_upgrade test for binary compatibility of core data types

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Jacob Champion <pchampion(at)vmware(dot)com>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, peter(dot)eisentraut(at)enterprisedb(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, buschmann(at)nidsa(dot)net, noah(at)leadboat(dot)com, tomas(dot)vondra(at)2ndquadrant(dot)com, bruce(at)momjian(dot)us, andres(at)anarazel(dot)de
Subject: Re: pg_upgrade test for binary compatibility of core data types
Date: 2021-09-13 13:20:37
Message-ID: ea3a2e19-4266-6be1-d5dc-497f3c0ce543@dunslane.net
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers


On 9/12/21 2:41 PM, Andrew Dunstan wrote:
> On 9/11/21 8:51 PM, Justin Pryzby wrote:
>> @Andrew: did you have any comment on this part ?
>>
>> |Subject: buildfarm xversion diff
>> |Forking https://www.postgresql.org/message-id/20210328231433.GI15100@telsasoft.com
>> |
>> |I gave suggestion how to reduce the "lines of diff" metric almost to nothing,
>> |allowing a very small "fudge factor", and which I think makes this a pretty
>> |good metric rather than a passable one.
>>
> Somehow I missed that. Looks like some good suggestions. I'll
> experiment. (Note: we can't assume the presence of sed, especially on
> Windows).
>
>

I tried with the attached patch on crake, which tests back as far as
9.2. Here are the diff counts from HEAD:

andrew(at)emma:HEAD $ grep -c '^[+-]' dumpdiff-REL9_* dumpdiff-REL_1*
dumpdiff-HEAD
dumpdiff-REL9_2_STABLE:514
dumpdiff-REL9_3_STABLE:169
dumpdiff-REL9_4_STABLE:185
dumpdiff-REL9_5_STABLE:221
dumpdiff-REL9_6_STABLE:11
dumpdiff-REL_10_STABLE:11
dumpdiff-REL_11_STABLE:73
dumpdiff-REL_12_STABLE:73
dumpdiff-REL_13_STABLE:73
dumpdiff-REL_14_STABLE:0
dumpdiff-HEAD:0

I've also attached those non-empty dumpdiff files for information, since
they are quite small.

There is still work to do, but this is promising. Next step: try it on
Windows.

cheers

andrew

--

Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
upgrade-diffs.patch text/x-patch 1.8 KB
dumpdiff-REL9_2_STABLE text/plain 41.5 KB
dumpdiff-REL9_3_STABLE text/plain 15.1 KB
dumpdiff-REL9_4_STABLE text/plain 16.3 KB
dumpdiff-REL9_5_STABLE text/plain 17.2 KB
dumpdiff-REL9_6_STABLE text/plain 1.2 KB
dumpdiff-REL_10_STABLE text/plain 1.2 KB
dumpdiff-REL_11_STABLE text/plain 9.5 KB
dumpdiff-REL_12_STABLE text/plain 9.5 KB
dumpdiff-REL_13_STABLE text/plain 9.5 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message arjun shetty 2021-09-13 13:59:11 Re: BUG #17185: PostgreSQL performance GNU vs LLVM
Previous Message David G. Johnston 2021-09-13 12:56:19 Re: BUG #17189: Index not created when primary key created

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-09-13 13:26:43 Re: [PATCH] Add --create-only option to pg_dump/pg_dumpall
Previous Message Justin Pryzby 2021-09-13 13:11:52 Re: proposal: possibility to read dumped table's name from file