pid_t on mingw

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: pid_t on mingw
Date: 2022-10-04 08:15:13
Message-ID: e9b1a94d-45d6-f05f-efb7-b03ee23cd4a7@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wanted to propose the attached patch to get rid of the custom pgpid_t
typedef in pg_ctl. Since we liberally use pid_t elsewhere, this seemed
plausible.

However, this patch fails the CompilerWarnings job on Cirrus, because
apparently under mingw, pid_t is "volatile long long int", so all the
printf placeholders mismatch. However, we print pid_t as %d in a lot of
other places, so I'm confused why this fails here.

Also, googling around a bit about this, it seems that mingw might have
changed the pid_t from long long int to int some time ago. Maybe that's
how the pgpid_t came about to begin with. The Cirrus job uses a
cross-compilation environment. I wonder how up to date that is compared
to say the native mingw installations used on the build farm.

Any clues?

Attachment Content-Type Size
0001-Remove-pgpid_t-type-use-pid_t-instead.patch text/plain 11.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2022-10-04 08:16:36 Re: Fix some newly modified tab-complete changes
Previous Message Michael Paquier 2022-10-04 08:05:40 Re: installcheck-world concurrency issues