| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Banck <michael(dot)banck(at)credativ(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: Logical replication existing data copy |
| Date: | 2017-03-23 22:22:52 |
| Message-ID: | e85135e8-688c-9776-570e-73028454ebda@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 23/03/17 23:06, Michael Banck wrote:
> Hi,
>
> On Thu, Mar 23, 2017 at 09:00:16AM -0400, Peter Eisentraut wrote:
>> On 3/21/17 21:38, Peter Eisentraut wrote:
>>> This patch is looking pretty good to me, modulo the failing pg_dump tests.
>>>
>>> Attached is a fixup patch. I have mainly updated some comments and
>>> variable naming for (my) clarity. No functional changes.
>>
>> Committed all that.
>
> Maybe I'm doing something wrong, but I'm getting a segfault trying to
> start logical replication since that patch went in.
>
Thanks for report. Looks like we don't handle correctly empty result set
when fetching table list. Will post fix tomorrow.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2017-03-23 22:45:36 | Re: Hash support for grouping sets |
| Previous Message | Euler Taveira | 2017-03-23 22:11:05 | Re: createlang/droplang deprecated |