Re: [Patch] Improve the test src/test/postmaster/t/003_start_stop.pl

From: "Potapov Alexander" <a(dot)potapov(at)postgrespro(dot)com>
To: "Heikki Linnakangas" <hlinnaka(at)iki(dot)fi>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [Patch] Improve the test src/test/postmaster/t/003_start_stop.pl
Date: 2025-12-12 07:09:09
Message-ID: e832bbff-2729-c000-59ce-c9aacdc13a00@postgrespro.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wednesday, December 10, 2025 16:28 MSK, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> This seems a little pointless because the test explicitly sets
> max_connectins and max_wal_senders. It's true that it currently uses
> more iterations than strictly necessary, but does it matter?

Sure, currently the test works fine. But if we exactly know that the pool size is '2*(MaxConnections + max_wal_senders)' why we do not apply it to the test? The additional benefit is if someone increase the pool size for instance '2*(MaxConnections + max_wal_senders) + some_value' the test fails and indicates an issue.

-- Alexander

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zsolt Parragi 2025-12-12 07:10:24 Re: Proposal: Add a callback data parameter to GetNamedDSMSegment
Previous Message jian he 2025-12-12 06:15:19 Re: ON CONFLICT DO SELECT (take 3)