Re: [Patch] Improve the test src/test/postmaster/t/003_start_stop.pl

On 10/12/2025 14:32, Potapov Alexander wrote:
> Hello,
>
> This is about the TAP test src/test/postmaster/t/003_start_stop.pl. The test contains a loop that performs 21 iterations in order to use all possible connection slots. We could calculate the number of available connections more accurately. It relates to the size of backend pool that is defined in src/backend/postmaster/pmchild.c:
>
> pmchild_pools[B_BACKEND].size = 2 * (MaxConnections + max_wal_senders);
>
> There are two points here: (1) in current implementation the test performs 11 extra iterations instead of 10 that are really needed. (2) We need to change the hardcoded value every time if the number of max connections or the number of max wal senders are changed. If we use 2 * (MaxConnections + max_wal_senders) the test becomes a bit convinent.

This seems a little pointless because the test explicitly sets
max_connectins and max_wal_senders. It's true that it currently uses
more iterations than strictly necessary, but does it matter?

- Heikki