| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: compute_query_id and pg_stat_statements |
| Date: | 2021-04-26 14:46:12 |
| Message-ID: | e832ac41-00dd-3a05-7f52-4b2ae4613508@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24.04.21 19:43, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>> That's a pretty weird API. I think we just need people to turn it on
>> like they are doing when the configure pg_stat_statements anyway.
>> pg_stat_statements already requires configuration anyway.
>
> Agreed. If pg_stat_statements were zero-configuration today then
> this would be an annoying new burden, but it isn't.
I think people can understand "add pg_stat_statements to
shared_preload_libraries" and "install the extension". You have to turn
it on somehow after all.
Now there is the additional burden of turning on this weird setting that
no one understands. That's a 50% increase in burden.
And almost no one will want to use a nondefault setting.
pg_stat_statements is pretty popular. I think leaving in this
requirement will lead to widespread confusion and complaints.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-04-26 14:55:42 | Re: Does rewriteTargetListIU still need to add UPDATE tlist entries? |
| Previous Message | Alvaro Herrera | 2021-04-26 14:36:29 | Re: Enhanced error message to include hint messages for redundant options error |