| From: | Jacob Champion <pchampion(at)vmware(dot)com> |
|---|---|
| To: | "aleksander(at)timescale(dot)com" <aleksander(at)timescale(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | "zyu(at)yugabyte(dot)com" <zyu(at)yugabyte(dot)com>, "pryzby(at)telsasoft(dot)com" <pryzby(at)telsasoft(dot)com>, "sawada(dot)mshk(at)gmail(dot)com" <sawada(dot)mshk(at)gmail(dot)com>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "soumyadeep2007(at)gmail(dot)com" <soumyadeep2007(at)gmail(dot)com>, Ashwin Agrawal <aashwin(at)vmware(dot)com>, "melanieplageman(at)gmail(dot)com" <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Table AM modifications to accept column projection lists |
| Date: | 2021-06-04 23:14:21 |
| Message-ID: | e82d48a8bbd617508f1e51606db9de7a63466636.camel@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2021-06-01 at 15:38 +0300, Aleksander Alekseev wrote:
> I came across this patch and noticed that it rotted a little,
> especially after removing inheritance_planner() in 86dc9005. I
> managed to resolve the conflicts on current `master` (eb89cb43), see
> the attached patch. The code compiles but doesn't pass the tests. I'm
> currently in the process of reviewing it and didn't figure out what
> the issue is yet. Just wanted to let you know.
Hi Alexsander, thanks!
In your patch's transformInsertStmt(), I see what I think is an
extraneous call to transformReturningList() right before the ON
CONFLICT processing. That call is already done later in the function,
during the RETURNING processing (this change came in with 6c0373ab77).
Other than that, your rebased patch looks the same as mine.
> I also believe changing the patch status to "Waiting on Author"
> would be appropriate.
Agreed. I'm going to double-check with Deep that the new calls
to table_tuple_fetch_row_version() should be projecting the full row,
then post an updated patch some time next week.
Thanks again!
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-06-04 23:21:11 | Re: Move pg_attribute.attcompression to earlier in struct for reduced size? |
| Previous Message | Jeremy Schneider | 2021-06-04 23:07:02 | Re: logical decoding bug: segfault in ReorderBufferToastReplace() |