| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Move pg_attribute.attcompression to earlier in struct for reduced size? |
| Date: | 2021-06-04 23:21:11 |
| Message-ID: | 202106042321.6jx54yliy2l6@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Jun-04, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Now, while this patch does seem to work correctly, it raises a number of
> > weird cpluspluscheck warnings, which I think are attributable to the
> > new macro definitions. I didn't look into it closely, but I suppose it
> > should be fixable given sufficient effort:
>
> Didn't test, but the first one is certainly fixable by adding a cast,
> and I guess the others might be as well.
I get no warnings with this one. I'm a bit wary of leaving
VARDATA_COMPRESSED_GET_EXTSIZE unchanged, but at least nothing in this
patch requires a cast there.
--
Álvaro Herrera Valdivia, Chile
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Reduce-overhead-of-TOAST-recompression-on-table-r.patch | text/x-diff | 4.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-04 23:23:04 | Re: join pushdown and issue with foreign update |
| Previous Message | Jacob Champion | 2021-06-04 23:14:21 | Re: Table AM modifications to accept column projection lists |