| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: Correction of RowMark Removal During Sel-Join Elimination |
| Date: | 2025-08-12 09:40:15 |
| Message-ID: | e7c8173c-91be-41a3-a390-2ca84fbc5147@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/8/2025 20:15, Greg Sabino Mullane wrote:
> I'm not convinced this is an improvement from someone just coming in to
> this part of the code, especially given (for example) the comment right
> above it:
>
> * Determine if the inner table can duplicate outer rows. We must
> * bypass the unique rel cache here since we're possibly using aThanks for your feedback.
I made some minor adjustments to the comments to make the code more
consistent. Sure, rrel and krel don't seem like the best solution - I
guess natives could find less wordy synonyms than just dumb
'keeping_rel' and 'removing_rel'. But it is simpler to track which
relation and RowMark should be removed.
--
regards, Andrei Lepikhov
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Force-RowMark-Sanity-Checking.patch | text/plain | 6.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2025-08-12 09:49:27 | Re: Adding locks statistics |
| Previous Message | Bertrand Drouvot | 2025-08-12 09:37:55 | Re: Adding locks statistics |