| From: | Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
|---|---|
| To: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: Correction of RowMark Removal During Sel-Join Elimination |
| Date: | 2025-08-11 18:15:46 |
| Message-ID: | CAKAnmmJzSGzTRaLATNZPErByO3-j6MwsK--qPSiRLJi4kB05HQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Basic concept looks good. However:
and fixes the incorrect behaviour. Additionally, it renames variables to
> make
> similar errors more apparent in the future.
- if (!innerrel_is_unique_ext(root, joinrelids, inner->relids,
> - outer, JOIN_INNER, selfjoinquals,
> + if (!innerrel_is_unique_ext(root, joinrelids, rrel->relids,
> + krel, JOIN_INNER, selfjoinquals,
I'm not convinced this is an improvement from someone just coming in to
this part of the code, especially given (for example) the comment right
above it:
* Determine if the inner table can duplicate outer rows. We must
* bypass the unique rel cache here since we're possibly using a
Cheers,
Greg
--
Crunchy Data - https://www.crunchydata.com
Enterprise Postgres Software Products & Tech Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2025-08-11 18:25:25 | Re: ReplicationSlotRelease() crashes when the instance is in the single user mode |
| Previous Message | Robert Haas | 2025-08-11 17:55:57 | Re: Extension security improvement: Add support for extensions with an owned schema |