Re: PATCH: Configurable file mode mask

From: David Steele <david(at)pgmasters(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Configurable file mode mask
Date: 2018-03-05 22:25:46
Message-ID: e795dbb2-d3ba-e6a5-3483-07e2ef5b842f@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Tom,

On 3/5/18 5:11 PM, Tom Lane wrote:
> David Steele <david(at)pgmasters(dot)net> writes:
>> On 2/28/18 2:28 AM, Michael Paquier wrote:
>>> That's basically a recursive chmod, so chmod_recursive is more adapted?
>>> I could imagine that this is useful as well for removing group
>>> permissions, so the new mode could be specified as an argument.
>
>> The required package (File::chmod::Recursive) for chmod_recursive is not
>> in use anywhere else and was not installed when I installed build
>> dependencies.
>
>> I'm not sure what the protocol for introducing a new Perl module is? I
>> couldn't find packages for the major OSes. Are we OK with using CPAN?
>
> I don't think that's cool. Anything that's not part of a standard Perl
> installation is a bit of a lift already, and if it's not packaged by
> major distros then it's really a problem for many people. (Yeah, they
> may know what CPAN is, but they might have local policy issues about
> installing directly from there.)

This is my view as well. I don't think CPAN should ever be on a
production box, mostly because of all the other tools that need to be
installed to make it work.

It's a little different here, because these packages are only used for
testing/development.

Of course, maybe I have this wrong and Michael will point out my error.
If not, I'm happy to rework the function (about 15 lines) to be more
generic.

--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2018-03-05 22:30:05 Re: PATCH: Configurable file mode mask
Previous Message Tom Lane 2018-03-05 22:11:29 Re: PATCH: Configurable file mode mask