| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: split TOAST support out of postgres.h |
| Date: | 2023-01-10 05:07:49 |
| Message-ID: | e6c67eca-f55e-4c8f-03f4-e6104c7373f4@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 30.12.22 17:50, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>> On 28.12.22 16:07, Tom Lane wrote:
>>> I dunno, #3 seems kind of unprincipled. Also, since fmgr.h is included
>>> so widely, I doubt it is buying very much in terms of reducing header
>>> footprint. How bad is it to do #2?
>
>> See this incremental patch set.
>
> Wow, 41 files requiring varatt.h is a lot fewer than I would have guessed.
> I think that bears out my feeling that fmgr.h wasn't a great location:
> I count 117 #includes of that, many of which are in .h files themselves
> so that many more .c files would be required to read them.
committed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Brar Piening | 2023-01-10 05:12:44 | Re: doc: add missing "id" attributes to extension packaging page |
| Previous Message | Justin Pryzby | 2023-01-10 04:57:22 | Re: typos |