Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
Date: 2025-11-04 10:40:01
Message-ID: e6129aad-0085-4bc3-8b5f-63fbee7b488a@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 31.10.25 18:08, Álvaro Herrera wrote:
> pg_createsubscriber: Fix error complaining about the wrong thing
>
> The code updates the system identifier, then runs pg_walreset; if the
> latter fails, it complains about the former, which makes no sense.
> Change the error message to complain about the right thing.

- pg_log_info("subscriber successfully changed the system identifier");
+ pg_log_info("subscriber successfully reset WAL on the subscriber");

Maybe that message has one "subscriber" too many?

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2025-11-04 11:14:47 pgsql: libpq: Improve error handling in passwordFromFile()
Previous Message Álvaro Herrera 2025-11-04 10:00:35 pgsql: Use USECS_PER_SEC from datatype/timestamp.h