Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
Date: 2025-11-06 09:56:14
Message-ID: cd594df7-e677-4e35-9a28-e9e929110339@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 04.11.25 11:40, Peter Eisentraut wrote:
> On 31.10.25 18:08, Álvaro Herrera wrote:
>> pg_createsubscriber: Fix error complaining about the wrong thing
>>
>> The code updates the system identifier, then runs pg_walreset; if the
>> latter fails, it complains about the former, which makes no sense.
>> Change the error message to complain about the right thing.
>
> - pg_log_info("subscriber successfully changed the system identifier");
> + pg_log_info("subscriber successfully reset WAL on the subscriber");
>
> Maybe that message has one "subscriber" too many?

I have fixed this.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2025-11-06 09:58:18 pgsql: Fix redundancy in error message
Previous Message John Naylor 2025-11-06 09:37:02 pgsql: Cosmetic fixes in GiST README