Re: Generate pg_stat_get_* functions with Macros

Hi,

On 12/3/22 1:51 AM, Nathan Bossart wrote:
> Overall, this change looks straightforward, and it saves a couple hundred
> lines.
>

Thanks for looking at it!

> On Tue, Nov 22, 2022 at 08:09:22AM +0100, Drouvot, Bertrand wrote:
>> +/* pg_stat_get_numscans */
>> +PGSTAT_DEFINE_REL_INT64_FIELD_ACCESSOR(pg_stat_get_, numscans);
>> +
>> +/* pg_stat_get_tuples_returned */
>> +PGSTAT_DEFINE_REL_INT64_FIELD_ACCESSOR(pg_stat_get_, tuples_returned);
>> +
>> +/* pg_stat_get_tuples_fetched */
>> +PGSTAT_DEFINE_REL_INT64_FIELD_ACCESSOR(pg_stat_get_, tuples_fetched);
>
> Can we hard-code the prefix in the macro? It looks like all of these use
> the same one.
>

Good point! Done in V2 attached.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com