| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Generate pg_stat_get_* functions with Macros |
| Date: | 2022-12-03 00:51:25 |
| Message-ID: | 20221203005125.GA2561471@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Overall, this change looks straightforward, and it saves a couple hundred
lines.
On Tue, Nov 22, 2022 at 08:09:22AM +0100, Drouvot, Bertrand wrote:
> +/* pg_stat_get_numscans */
> +PGSTAT_DEFINE_REL_INT64_FIELD_ACCESSOR(pg_stat_get_, numscans);
> +
> +/* pg_stat_get_tuples_returned */
> +PGSTAT_DEFINE_REL_INT64_FIELD_ACCESSOR(pg_stat_get_, tuples_returned);
> +
> +/* pg_stat_get_tuples_fetched */
> +PGSTAT_DEFINE_REL_INT64_FIELD_ACCESSOR(pg_stat_get_, tuples_fetched);
Can we hard-code the prefix in the macro? It looks like all of these use
the same one.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-12-03 02:45:30 | Re: Add LZ4 compression in pg_dump |
| Previous Message | Nathan Bossart | 2022-12-03 00:31:58 | Re: WAL Insertion Lock Improvements (was: Re: Avoid LWLockWaitForVar() for currently held WAL insertion lock in WaitXLogInsertionsToFinish()) |