Re: [PATCH] Cleanup of GUC units code

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Asko Oja" <ascoja(at)gmail(dot)com>, "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Cleanup of GUC units code
Date: 2008-09-02 22:44:06
Message-ID: e51f66da0809021544o5bac8ea8l1d1939be3ebf1515@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 9/3/08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Asko Oja" <ascoja(at)gmail(dot)com> writes:
> > Anything that will reduce potential downtime should be way to go.
>
> That argument didn't seem to me to be worth the electrons to rebut,
> but now that someone else has repeated it, maybe I should. It's
> ludicrous to claim that allowing case insensitivity here will make
> any noticeable improvement in downtime, as there are far more ways
> to screw up your config file than this one. (A config file test mode,
> such as was discussed a few weeks ago, *would* help, but this won't.)
> In the light of Peter's argument about confusion, one could even
> argue that admins putting in wrong values because they got confused
> about the meaning of the units is a downtime risk in itself.

How can the meaning of "gb", "mb", "kb" be uncertain?

But currently writing "kb" *will* load database with wrong values.

--
marko

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2008-09-02 23:19:26 Re: [HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker)
Previous Message Marko Kreen 2008-09-02 22:40:03 Re: [PATCH] Cleanup of GUC units code