Re: [PATCH] Cleanup of GUC units code

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Cleanup of GUC units code
Date: 2008-09-02 22:40:03
Message-ID: e51f66da0809021540j54a08bf7pdc24a9d4ec4f1e65@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 9/3/08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> > "Marko Kreen" <markokr(at)gmail(dot)com> writes:
> >> Uh. So you want force "proper" units in presentations at the price
> >> of everyday admin operations? Does not seem like a sensible tradeoff.
>
> > It didn't to anyone else when Peter wrote the current version either, but as
> > the person willing to actually do the work and write the code Peter got to
> > make the decision. Nobody else stepped up to do the work to change it and we
> > can't exactly force Peter to do work he doesn't agree with.
>
>
> It's not that, in my mind: it's that Peter feels more strongly about it
> than the rest of us. This proposal has come up before and he's
> successfully argued it down each time. He does have a point about there
> being some potential for confusion; and the arguments on the other side
> are not much better than "I'm lazy". Being lazy myself, I'd prefer a
> case insensitive implementation; but I don't feel strongly enough about
> it to want to override Peter's opinion.

Um, being lazy is *the point* of units!? And being friendly to
newbies. Can there be any other reason for their existence?

--
marko

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Kreen 2008-09-02 22:44:06 Re: [PATCH] Cleanup of GUC units code
Previous Message Tom Lane 2008-09-02 22:39:26 Re: Feature request: better debug messages