Re: pgsql: pg_validatebackup: Adjust TAP tests to placate perlcritic.

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pg_validatebackup: Adjust TAP tests to placate perlcritic.
Date: 2020-04-03 21:40:12
Message-ID: e2bf48bd-3525-d4c5-34d7-5748683207bb@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 4/3/20 3:32 PM, Robert Haas wrote:
> pg_validatebackup: Adjust TAP tests to placate perlcritic.
>
> It seems that we have a policy that every Perl subroutine should
> end with an explicit "return", so add explicit "return"
> statements to all the new subroutines added by my prior
> commit 0d8c9c1210c44b36ec2efcb223a1dfbe897a3661.

It was discussed here 
https://postgr.es/m/CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2020-04-03 23:07:42 pgsql: pg_validatebackup: Adjust TAP tests to undo permissions change.
Previous Message Robert Haas 2020-04-03 21:19:00 pgsql: pg_validatebackup: Also use perl2host in TAP tests.