| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: pg_validatebackup: Adjust TAP tests to placate perlcritic. |
| Date: | 2020-04-03 23:45:43 |
| Message-ID: | CA+TgmobjGn7vJ62_TgSgR6xmBK5ofRbTyxy8Yx_4_D-f5SLgTg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Apr 3, 2020 at 5:40 PM Andrew Dunstan
<andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
> On 4/3/20 3:32 PM, Robert Haas wrote:
> > pg_validatebackup: Adjust TAP tests to placate perlcritic.
> >
> > It seems that we have a policy that every Perl subroutine should
> > end with an explicit "return", so add explicit "return"
> > statements to all the new subroutines added by my prior
> > commit 0d8c9c1210c44b36ec2efcb223a1dfbe897a3661.
>
> It was discussed here
> https://postgr.es/m/CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com
Yeah, I understand that I probably should have been aware of this. I
just wasn't.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-04-03 23:55:58 | pgsql: pg_validatebackup: Fix 'make clean' to remove tmp_check. |
| Previous Message | Robert Haas | 2020-04-03 23:07:42 | pgsql: pg_validatebackup: Adjust TAP tests to undo permissions change. |