| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Dimitrios Apostolou <jimis(at)gmx(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Tomas Vondra <tomas(at)vondra(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: [PING] fallocate() causes btrfs to never compress postgresql files |
| Date: | 2026-02-06 15:33:55 |
| Message-ID: | e1f0cd3b-0164-45f5-9705-e922e59df90f@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-02-06 Fr 10:11 AM, Tom Lane wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
>> BTW the rest of the patches will reemerge for master, but for the
>> minimal one back-patched: crake complains about an ABI break due to
>> GUC table changes. Of course adding a GUC to the stable branches is
>> unusual and we discussed the need for it in this case. Is that
>> expected? In what way is it part of the ABI? How would one determine
>> in advance that the ABI checker will complain?
> We have very little experience so far with libabigail, so there's
> not any store of knowledge hereabouts on what it'll complain about.
>
> The message is complaining that sizeof(ConfigureNamesEnum) changed,
> which it did, but I don't see how that value would be visible to
> external modules. So maybe a bug in libabigail?
>
>
I guess because of this in guc_tables.h:
extern PGDLLIMPORT struct config_generic ConfigureNames[];
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | hubert depesz lubaczewski | 2026-02-06 15:35:28 | Re: Add CREATE SCHEMA ... LIKE support |
| Previous Message | David G. Johnston | 2026-02-06 15:30:17 | Add CREATE SCHEMA ... LIKE support |