| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Dimitrios Apostolou <jimis(at)gmx(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Tomas Vondra <tomas(at)vondra(dot)me>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: [PING] fallocate() causes btrfs to never compress postgresql files |
| Date: | 2026-02-06 18:31:02 |
| Message-ID: | 1802017.1770402662@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 2026-02-06 Fr 10:11 AM, Tom Lane wrote:
>> The message is complaining that sizeof(ConfigureNamesEnum) changed,
>> which it did, but I don't see how that value would be visible to
>> external modules. So maybe a bug in libabigail?
> I guess because of this in guc_tables.h:
> extern PGDLLIMPORT struct config_generic ConfigureNames[];
Evidently, but I don't see how that provides a sizeof() value to
onlookers. Just to be sure, I tried to compile a use of that,
and got
test.c:43:53: error: invalid application of ‘sizeof’ to incomplete type ‘struct config_generic[]’
elog(NOTICE, "sizeof(ConfigureNames) = %zu", sizeof(ConfigureNames));
^
So if this isn't an outright bug, it's at least unhelpful behavior.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-02-06 19:40:35 | Re: pg_upgrade: transfer pg_largeobject_metadata's files when possible |
| Previous Message | KAZAR Ayoub | 2026-02-06 18:11:37 | Re: Speed up COPY FROM text/CSV parsing using SIMD |