Re: buildfarm + meson

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: buildfarm + meson
Date: 2023-03-09 13:28:42
Message-ID: e1b6014b-bf5a-28aa-6fef-a8472e3bf25f@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-03-08 We 17:23, Andrew Dunstan wrote:
>
>
> On 2023-03-08 We 14:22, Andres Freund wrote:
>> Hi,
>>
>> On 2023-03-02 17:35:26 -0500, Andrew Dunstan wrote:
>>> On 2023-03-02 Th 17:06, Andres Freund wrote:
>>>> Hi
>>>>
>>>> On 2023-03-02 17:00:47 -0500, Andrew Dunstan wrote:
>>>>> On 2023-03-01 We 16:32, Andres Freund wrote:
>>>>>>> This is now working
>>>>>>> on my MSVC test rig (WS2019, VS2019, Strawberry Perl), including TAP tests.
>>>>>>> I do get a whole lot of annoying messages like this:
>>>>>>>
>>>>>>> Unknown TAP version. The first line MUST be `TAP version <int>`. Assuming
>>>>>>> version 12.
>>>>>> The newest minor version has fixed that, it was a misunderstanding about /
>>>>>> imprecision in the tap 14 specification.
>>>>>>
>>>>> Unfortunately, meson v 1.0.1 appears to be broken on Windows, I had to
>>>>> downgrade back to 1.0.0.
>>>> Is it possible that you're using a PG checkout from a few days ago? A
>>>> hack I used was invalidated by 1.0.1, but I fixed that already.
>>>>
>>>> CI is running with 1.0.1:
>>>> https://cirrus-ci.com/task/5806561726038016?logs=configure#L8
>>>>
>>> No, running against PG master tip. I'll get some details - it's not too hard
>>> to switch back and forth.
>> Any more details?
>
>
> I was held up by difficulties even with meson 1.0.0 (the test modules
> stuff). Now I again have a clean build with meson 1.0.0 on Windows as
> a baseline I will get back to trying meson 1.0.1.
>
>

OK, I have now got a clean run using meson 1.0.1 / MSVC. Not sure what
made the difference. One change I did make was to stop using "--backend
vs" and thus use the ninja backend even for MSVC. That proved necessary
to run the new install-test-files target which failed miserably with
"--backend vs". Not sure if we have it documented, but if not it should
be that you need to use the ninja backend on all platforms.

At this stage I think I'm prepared to turn this loose on a couple of my
buildfarm animals, and if nothing goes awry for the remainder of the
month merge the dev/meson branch and push a new release.

There is still probably a little polishing to do, especially w.r.t. log
file artefacts.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-03-09 13:45:24 Re: meson: Non-feature feature options
Previous Message Melanie Plageman 2023-03-09 13:23:46 Re: Add shared buffer hits to pg_stat_io