Re: Patches that don't apply or don't compile: 2017-09-12

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Cc: "Bossart, Nathan" <bossartn(at)amazon(dot)com>, "yangjie(at)highgo(dot)com" <yangjie(at)highgo(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Anton Dignös <dignoes(at)inf(dot)unibz(dot)it>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Elvis Pranskevichus <elprans(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Jeff Davis <pgsql(at)j-davis(dot)com>, Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Mark Rofail <markm(dot)rofail(at)gmail(dot)com>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info>, Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Sokolov Yura <funny(dot)falcon(at)postgrespro(dot)ru>, Tianzhou Chen <tianzhouchen(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Victor Drobny <v(dot)drobny(at)postgrespro(dot)ru>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Subject: Re: Patches that don't apply or don't compile: 2017-09-12
Date: 2017-09-12 14:55:26
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 09/12/2017 04:14 PM, Aleksander Alekseev wrote:
> Title: Foreign Key Arrays
> Author: Mark Rofail<markm(dot)rofail(at)gmail(dot)com>
> URL:

I am currently reviewing this one and it applies, compiles, and passes
the test suite. It could be the compilation warnings which makes the
system think it failed, but I could not find the log of the failed build.

We want to be welcoming to new contributors so until we have a reliable
CI server which can provide easy to read build logs I am against
changing the status of any patches solely based on the result of the CI
server. I think it should be used as a complimentary tool until the
community deems it to be good enough.


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-09-12 15:21:53 Re: WIP patch: distinguish selectivity of < from <= and > from >=
Previous Message Ildus Kurbangaliev 2017-09-12 14:55:05 Re: Custom compression methods