| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] path toward faster partition pruning |
| Date: | 2017-12-22 02:13:40 |
| Message-ID: | dfdf27c3-aad1-9386-30db-b8b46731a110@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/12/22 1:06, Alvaro Herrera wrote:
> Just trying to understand the code here; some very minor comments as I
> go along.
>
> partition_op_strategy returning int32 looks pretty ugly, and the calling
> code is not super-intelligible either. How about returning a value from
> a new enum?
OK, I made it the following enum:
typedef enum PartOpStrategy
{
PART_OP_EQUAL,
PART_OP_LESS,
PART_OP_GREATER,
} PartOpStrategy;
> typedef PartClause is missing a struct name, as is our tradition.
Will fix.
>> + * We don't a <> operator clause into a key right away.
>
> Missing a word there.
Oops, right. I meant "We don't turn a <> ...". Will fix.
Will post a new version after taking care of David's comments.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2017-12-22 02:15:35 | Re: Finalizing logical replication limitations as well as potential features |
| Previous Message | Gene Selkov | 2017-12-22 01:39:49 | Re: genomic locus |