Re: [HACKERS] path toward faster partition pruning

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] path toward faster partition pruning
Date: 2017-12-21 16:06:19
Message-ID: 20171221160619.olg7wh6e6z53evb3@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Just trying to understand the code here; some very minor comments as I
go along.

partition_op_strategy returning int32 looks pretty ugly, and the calling
code is not super-intelligible either. How about returning a value from
a new enum?

typedef PartClause is missing a struct name, as is our tradition.

> + * We don't a <> operator clause into a key right away.

Missing a word there.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-12-21 16:11:44 Re: pgsql: Add parallel-aware hash joins.
Previous Message Robert Haas 2017-12-21 15:44:24 Re: force parallel mode vs CTAS