Re: pgsql: Get rid of backtracking in jsonpath_scan.l

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Get rid of backtracking in jsonpath_scan.l
Date: 2019-03-26 16:36:05
Message-ID: de9f5dee-30ef-439e-dfe9-a02129adbe8f@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 3/26/19 11:22 AM, Alvaro Herrera wrote:
> On 2019-Mar-26, Andrew Dunstan wrote:
>
>> On 3/25/19 8:44 AM, Alexander Korotkov wrote:
>>> Get rid of backtracking in jsonpath_scan.l
>>>
>>> Non-backtracking flex parsers work faster than backtracking ones. So, this
>>> commit gets rid of backtracking in jsonpath_scan.l. That required explicit
>>> handling of some cases as well as manual backtracking for some cases. More
>>> regression tests for numerics are added.
>> jacana appears to be having trouble with this:
>>
>>
>> 2019-03-26 00:49:02.208 EDT [5c99ae9e.20cc:6] LOG: server process (PID 8368) was terminated by exception 0xC0000028
> 0xC0000028 is STATUS_BAD_STACK, per
> https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-erref/596a1078-e883-4972-9bbc-49e60bebca55
> Not sure how credible/useful a stack trace is going to be.
>

Right, and getting stack traces isn't easy in any case. There is a
gadget from Google that is supposed to trap exceptions and produce a
stack trace on the fly in mingw. I'm going to take a look at it,
although loading it might be ... interesting.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2019-03-26 16:53:02 Re: pgsql: Get rid of backtracking in jsonpath_scan.l
Previous Message Alvaro Herrera 2019-03-26 16:07:25 pgsql: psql: Schema-qualify typecast in one \d query

Browse pgsql-hackers by date

  From Date Subject
Next Message Ritom Sonowal 2019-03-26 16:39:33 Re: PostgreSQL Participates in GSoC 2019!
Previous Message Andres Freund 2019-03-26 16:35:33 Re: Tid scan improvements