Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jürgen Strobel <juergen+postgresql(at)strobel(dot)info>, Amit Langote <amitlangote09(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation
Date: 2018-11-12 04:17:35
Message-ID: dd9a44a1-e7a5-4a2e-2830-afdd793cdb9c@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2018/11/12 12:59, Tom Lane wrote:
> Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> writes:
>> On 2018/11/10 7:33, Tom Lane wrote:
>>> I'd argue not, actually. I think there is plausible precedent in
>>> updatable views, where what we use is the defaults associated with the
>>> view, not the underlying table. Correspondingly, what ought to govern
>>> in a partitioned insert is the defaults associated with the table actually
>>> named in the insert command, never mind what its partitions might say.
>>> That is useful for many situations, and it avoids all the logical
>>> inconsistencies you get into if you find that the defaults associated
>>> with some partition would force re-routing elsewhere.
>
>> ...
>> IOW, it might be a good idea to call the ability to set partition-level
>> defaults a deprecated feature?
>
> Not necessarily. They'd apply when you insert directly into a particular
> partition by name.

Yes. Maybe, we should document that the partition default are not honored
when inserting through the parent.

Thanks,
Amit

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2018-11-12 05:19:25 Re: BUG #15492: pg_cancel_backend(pg_backend_pid()) returns true sporadically
Previous Message Alexander Lakhin 2018-11-12 04:01:21 Re: BUG #15492: pg_cancel_backend(pg_backend_pid()) returns true sporadically

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2018-11-12 04:18:39 Re: csv format for psql
Previous Message Michael Paquier 2018-11-12 04:08:38 Re: Adding a TAP test checking data consistency on standby with minRecoveryPoint