| From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [BUG] failed assertion in EnsurePortalSnapshotExists() |
| Date: | 2021-10-01 05:27:42 |
| Message-ID: | dcbcffe1-148e-fe54-ead1-f26aa096c950@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/30/21 8:25 PM, Tom Lane wrote:
> "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> writes:
>> On 9/30/21 7:16 PM, Tom Lane wrote:
>>> PS: Memo to self: in the back branches, the new field has to be
>>> added at the end of struct Portal.
>> out of curiosity, why?
> Sticking it into the middle would create an ABI break for any
> extension code that's looking at struct Portal, due to movement
> of existing field offsets. In HEAD that's fine, so we should
> put the field where it makes the most sense. But we have to
> be careful about changing globally-visible structs in released
> branches.
Got it, thanks!
Bertrand
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-10-01 05:50:20 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Michael Paquier | 2021-10-01 05:11:15 | Re: Incorrect snapshots while promoting hot standby node when 2PC is used |