Re: [BUG] failed assertion in EnsurePortalSnapshotExists()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [BUG] failed assertion in EnsurePortalSnapshotExists()
Date: 2021-09-30 18:25:27
Message-ID: 3181300.1633026327@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> writes:
> On 9/30/21 7:16 PM, Tom Lane wrote:
>> PS: Memo to self: in the back branches, the new field has to be
>> added at the end of struct Portal.

> out of curiosity, why?

Sticking it into the middle would create an ABI break for any
extension code that's looking at struct Portal, due to movement
of existing field offsets. In HEAD that's fine, so we should
put the field where it makes the most sense. But we have to
be careful about changing globally-visible structs in released
branches.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jaime Casanova 2021-09-30 18:31:16 Re: FETCH FIRST clause PERCENT option
Previous Message Tom Lane 2021-09-30 18:17:16 Re: [EXTERNAL] Re: Add ETIMEDOUT to ALL_CONNECTION_FAILURE_ERRNOS