Re: [PATCH] Suppress Clang 3.9 warnings

From: David Steele <david(at)pgmasters(dot)net>
To: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Suppress Clang 3.9 warnings
Date: 2017-03-13 14:19:57
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi Aleksander,

On 2/22/17 9:43 AM, Fabien COELHO wrote:
> Hello Aleksander,
>> ```
>> xloginsert.c:742:18: warning: implicit conversion from 'int' to 'char'
>> changes value from 253 to -3 [-Wconstant-conversion]
>> ```
> There is a bunch of these in "xlog.c" as well, and the same code is used
> in "pg_resetwal.c".
>> Patch that fixes these warnings is attached to this email.
> My 0.02€:
> I'm not at ease at putting the thing bluntly under the carpet with a cast.
> Why not update the target type to "unsigned char" instead, so that no
> cast is needed and the value compatibility is checked by the compiler? I
> guess there would be some more changes (question is how much), but it
> would be cleaner.

There's been no discussion or new patch on this thread recently. If you
are planning to address the issues raised please plan to do so by
Thursday, March 16th.

If no new patch is submitted by that date I will mark this patch
"Returned with Feedback".


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Sharma 2017-03-13 14:36:25 Re: WAL Consistency checking for hash indexes
Previous Message Tom Lane 2017-03-13 14:19:37 Re: [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.