> ``` > xloginsert.c:742:18: warning: implicit conversion from 'int' to 'char' > changes value from 253 to -3 [-Wconstant-conversion] > ```
There is a bunch of these in "xlog.c" as well, and the same code is used in "pg_resetwal.c".
> Patch that fixes these warnings is attached to this email.
I'm not at ease at putting the thing bluntly under the carpet with a cast.
Why not update the target type to "unsigned char" instead, so that no cast is needed and the value compatibility is checked by the compiler? I guess there would be some more changes (question is how much), but it would be cleaner.