Re: [PATCH] Suppress Clang 3.9 warnings

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Suppress Clang 3.9 warnings
Date: 2017-02-22 14:43:34
Message-ID: alpine.DEB.2.20.1702221532100.22403@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Aleksander,

> ```
> xloginsert.c:742:18: warning: implicit conversion from 'int' to 'char'
> changes value from 253 to -3 [-Wconstant-conversion]
> ```

There is a bunch of these in "xlog.c" as well, and the same code is used
in "pg_resetwal.c".

> Patch that fixes these warnings is attached to this email.

My 0.02€:

I'm not at ease at putting the thing bluntly under the carpet with a cast.

Why not update the target type to "unsigned char" instead, so that no cast
is needed and the value compatibility is checked by the compiler? I guess
there would be some more changes (question is how much), but it would be


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2017-02-22 14:58:42 Re: GRANT EXECUTE ON FUNCTION foo() TO bar();
Previous Message Tom Lane 2017-02-22 14:35:54 Re: remove deprecated COMMENT ON RULE syntax