Re: [PATCH] Little refactoring of portalcmds.c

From: Quan Zongliang <quanzongliang(at)yeah(dot)net>
To: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Little refactoring of portalcmds.c
Date: 2025-10-27 06:02:41
Message-ID: dbe56aa6-76df-4824-a621-ffb890dbbfde@yeah.net
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/8/25 10:02 PM, Aleksander Alekseev wrote:
> Hi,
>
> The proposed patch places some repetitive code in a helper function.
> The value of this change is arguably not that high but it makes the
> code a bit neater IMO.
>

It also reduces the ease of reading the code.
Just add a function for a single if statement. I don't think it's necessary.

Regards,
Quan Zongliang

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2025-10-27 06:18:37 Re: Optimize LISTEN/NOTIFY
Previous Message shveta malik 2025-10-27 05:36:21 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart