Re: [PATCH] Little refactoring of portalcmds.c

Hi Aleksander Alekseev
> The proposed patch places some repetitive code in a helper function.
> The value of this change is arguably not that high but it makes the
> code a bit neater IMO.
I agree with your suggestion to refactor the duplicated code into a
function.

Thanks

On Mon, Oct 27, 2025 at 2:03 PM Quan Zongliang <quanzongliang(at)yeah(dot)net>
wrote:

>
>
> On 10/8/25 10:02 PM, Aleksander Alekseev wrote:
> > Hi,
> >
> > The proposed patch places some repetitive code in a helper function.
> > The value of this change is arguably not that high but it makes the
> > code a bit neater IMO.
> >
>
> It also reduces the ease of reading the code.
> Just add a function for a single if statement. I don't think it's
> necessary.
>
> Regards,
> Quan Zongliang
>
>
>
>