| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Dave Cramer <davecramer(at)postgres(dot)rocks>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Tony Locke <tlocke(at)tlocke(dot)org(dot)uk>, Shay Rojansky <roji(at)roji(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>, "Haumacher, Bernhard" <haui(at)haumacher(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Error on failed COMMIT |
| Date: | 2021-03-25 16:04:44 |
| Message-ID: | db006091-22f8-25f7-2ab5-79a2dff9904b@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/26/21 1:02 PM, Dave Cramer wrote:
> On Tue, 26 Jan 2021 at 12:46, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at
> <mailto:laurenz(dot)albe(at)cybertec(dot)at>> wrote:
>
> I see your point from the view of the JDBC driver.
>
> It just feels hacky - somewhat similar to what you say
> above: don't go through the normal transaction rollback steps,
> but issue an error message.
>
> At least we should fake it well...
>
> OK, let me look into how we deal with COMMIT and CHAIN.
>
> I can see some real issues with this as Vik pointed out.
Test are failing on the cfbot for this patch and it looks like a new
patch is needed from Dave, at the least, so marking Waiting on Author.
Should we be considering this patch Returned with Feedback instead?
Regards,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-03-25 16:13:44 | Re: [HACKERS] Custom compression methods |
| Previous Message | Jacob Champion | 2021-03-25 15:54:10 | Re: DETAIL for wrong scram password |