| From: | Dave Cramer <davecramer(at)postgres(dot)rocks> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Tony Locke <tlocke(at)tlocke(dot)org(dot)uk>, Shay Rojansky <roji(at)roji(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>, "Haumacher, Bernhard" <haui(at)haumacher(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Error on failed COMMIT |
| Date: | 2021-03-25 19:07:17 |
| Message-ID: | CADK3HHKOZtqQKLDbxxvmbgqHpNaGn-YLCprru=iTGb6uaWdH9w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 25 Mar 2021 at 12:04, David Steele <david(at)pgmasters(dot)net> wrote:
> On 1/26/21 1:02 PM, Dave Cramer wrote:
> > On Tue, 26 Jan 2021 at 12:46, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at
> > <mailto:laurenz(dot)albe(at)cybertec(dot)at>> wrote:
> >
> > I see your point from the view of the JDBC driver.
> >
> > It just feels hacky - somewhat similar to what you say
> > above: don't go through the normal transaction rollback steps,
> > but issue an error message.
> >
> > At least we should fake it well...
> >
> > OK, let me look into how we deal with COMMIT and CHAIN.
> >
> > I can see some real issues with this as Vik pointed out.
>
> Test are failing on the cfbot for this patch and it looks like a new
> patch is needed from Dave, at the least, so marking Waiting on Author.
>
> Should we be considering this patch Returned with Feedback instead?
>
>
Not sure, at this point the impetus for this is not getting a lot of
traction.
Honestly I think the approach I took is too simple and I don't have the
inclination at the moment to
rewrite it.
Dave Cramer
www.postgres.rocks
> Regards,
> --
> -David
> david(at)pgmasters(dot)net
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2021-03-25 19:23:53 | Re: Error on failed COMMIT |
| Previous Message | Robert Haas | 2021-03-25 19:05:55 | Re: shared memory stats: high level design decisions: consistency, dropping |