Re: minor refactor on src/test/modules/test_ddl_deparse/sql/alter_table.sql

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: minor refactor on src/test/modules/test_ddl_deparse/sql/alter_table.sql
Date: 2025-12-10 17:32:18
Message-ID: d96f70f7-fc11-497f-b769-6562b5a2d275@iki.fi
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 25/08/2025 04:05, Chao Li wrote:
>> On Aug 25, 2025, at 08:00, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>> in src/test/modules/test_ddl_deparse/sql/alter_table.sql:
>>
>> ----
>> The test initially focuses on the "parent" table, then switches to the
>> "part"
>> table, and goes back to the "parent" table.
>> This seems weird?  so I slightly adjusted the order to cover the "parent"
>> table first, followed by the "part" table.
>
> I think this change makes the test more organized.

Agreed, it looks a bit weird.

>> src/test/modules/test_ddl_deparse/sql/alter_table.sql
>> don't have ALTER TABLE ALTER COLUMN SET EXPRESSION,
>> so I added a test on it.
>> <v1-0001-refactor-test_ddl_deparse-sql-alter_table.sql.patch>
>
>
> I confirm “make check” passed with this patch.

Committed, thanks!

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2025-12-10 17:41:44 Re: Proposal to allow setting cursor options on Portals
Previous Message Sami Imseih 2025-12-10 17:30:19 Re: [PATCH] Add last_executed timestamp to pg_stat_statements