Re: minor refactor on src/test/modules/test_ddl_deparse/sql/alter_table.sql

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: minor refactor on src/test/modules/test_ddl_deparse/sql/alter_table.sql
Date: 2025-08-25 01:05:31
Message-ID: BB3AE058-E281-4FA8-A6BC-747C7B552581@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Aug 25, 2025, at 08:00, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> hi.
>
> in src/test/modules/test_ddl_deparse/sql/alter_table.sql:
>
> ----
> The test initially focuses on the "parent" table, then switches to the "part"
> table, and goes back to the "parent" table.
> This seems weird? so I slightly adjusted the order to cover the "parent"
> table first, followed by the "part" table.

I think this change makes the test more organized.

>
> src/test/modules/test_ddl_deparse/sql/alter_table.sql
> don't have ALTER TABLE ALTER COLUMN SET EXPRESSION,
> so I added a test on it.
> <v1-0001-refactor-test_ddl_deparse-sql-alter_table.sql.patch>

I confirm “make check” passed with this patch.

--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2025-08-25 01:30:32 Re: vacuumdb --missing-stats-only and permission issue
Previous Message Chao Li 2025-08-25 00:54:43 Fixes a trivial bug in dumped parse/query/plan trees