Re: Cleaning up and speeding up string functions

From: ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker )
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cleaning up and speeding up string functions
Date: 2019-07-22 16:00:43
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:

> On 2019-Jul-22, Dagfinn Ilmari Mannsåker wrote:
>> ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker) writes:
>> > I noticed a lot of these are appending one StringInfo onto another;
>> > would it make sense to introduce a helper funciton
>> > appendStringInfoStringInfo(StringInfo str, StringInfo str2) to avoid the
>> > `, str2.len` repetition?
>> A bit of grepping only turned up 18 uses, but I was bored and whipped up
>> the attached anyway, in case we decide it's worth it.
> David had already submitted the same thing upthread, and it was rejected
> on the grounds that it increases the code space.

Oops, sorry, I missed that. Never mind then.

- ilmari
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
the consequences of." -- Skud's Meta-Law

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-07-22 16:07:00 Re: Speed up transaction completion faster after many relations are accessed in a transaction
Previous Message Tom Lane 2019-07-22 15:57:13 Re: Add parallelism and glibc dependent only options to reindexdb